Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up a channel that was dangling #620

Merged
merged 1 commit into from
Apr 30, 2020
Merged

clean up a channel that was dangling #620

merged 1 commit into from
Apr 30, 2020

Conversation

willscott
Copy link
Contributor

minor. noticed while looking at why a lock had contention.

Stebalien
Stebalien approved these changes Apr 30, 2020
View reviewed changes
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if there's any real reason to do this, but it doesn't seem to cause any issues.

@willscott willscott merged commit f006c07 into master Apr 30, 2020
@willscott willscott deleted the fix/readcleanup branch April 30, 2020 00:40
@Stebalien Stebalien mentioned this pull request May 26, 2020
Closed
77 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

@aschmahmann aschmahmann Awaiting requested review from aschmahmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willscott @Stebalien